fix(tui): restore server config reading in TUI startup#23232
Open
GoldJohnKing wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): restore server config reading in TUI startup#23232GoldJohnKing wants to merge 1 commit intoanomalyco:devfrom
GoldJohnKing wants to merge 1 commit intoanomalyco:devfrom
Conversation
The TUI thread was changed to use resolveNetworkOptionsNoConfig(args) without passing the config parameter, causing opencode.json server settings (port, hostname, cors, mdns) to be completely ignored. This restored the resolveNetworkOptions(args) call which reads config via Config.Service, matching the v1.4.0 behavior. Closes anomalyco#23230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23230
Type of change
What does this PR do?
The TUI thread (
thread.ts) was changed to callresolveNetworkOptionsNoConfig(args)without passing theconfigparameter. This causesopencode.jsonserver settings (port,hostname,cors,mdns) to be completely ignored, since allconfig?.server.*values resolve toundefined.The fix restores the call to
resolveNetworkOptions(args), which reads the global config viaConfig.Servicebefore resolving network options. This matches the v1.4.0 behavior.The change: 2 lines — swap the import and make the call async with config loading.
How did you verify your code works?
Reproduced the issue on v1.4.11:
server.hostname: "0.0.0.0"andserver.port: 4096inopencode.jsonss -tlnpshowed nothing on 4096)0.0.0.0:4096Checklist