fix(plugin): add env parameter to WorkspaceAdaptor.create type#23235
Open
jamesmurdza wants to merge 1 commit intoanomalyco:devfrom
Open
fix(plugin): add env parameter to WorkspaceAdaptor.create type#23235jamesmurdza wants to merge 1 commit intoanomalyco:devfrom
jamesmurdza wants to merge 1 commit intoanomalyco:devfrom
Conversation
Align the published plugin type with the control-plane signature in packages/opencode/src/control-plane/types.ts, which already declares `env` as the second parameter and is what the runtime invokes at packages/opencode/src/control-plane/workspace.ts:121. No runtime change. Closes anomalyco#23233
github-actions
bot
added
contributor
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thank you! |
jlongster
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the published plugin type with the control-plane signature in
packages/opencode/src/control-plane/types.ts, which already declaresenvas the second parameter and matches the runtime invocation atpackages/opencode/src/control-plane/workspace.ts:121. No runtime change.Issue for this PR
Closes #23233
Type of change
What does this PR do?
Aligns the published plugin type with the control-plane signature. The control-plane type and call site already agree; only the plugin-facing type was inconsistent. Plugin authors implementing custom remote workspace adaptors lacked the
envparameter increate, so forwarded env vars (OPENCODE_AUTH_CONTENT, OPENCODE_WORKSPACE_ID, OPENCODE_EXPERIMENTAL_WORKSPACES, OTEL_EXPORTER_OTLP_*) never reached the sandbox.How did you verify your code works?
Ran
bun run typecheckinpackages/plugin→ passes. The widened type is safe: TypeScript allows implementations with fewer parameters, so adaptors typed as(config)or(config, env)still compile.Screenshots / recordings
N/A — type-only change.
Checklist