fix(web): make fallback model visible in model selector#23246
Open
shadowabi wants to merge 2 commits intoanomalyco:devfrom
Open
fix(web): make fallback model visible in model selector#23246shadowabi wants to merge 2 commits intoanomalyco:devfrom
shadowabi wants to merge 2 commits intoanomalyco:devfrom
Conversation
The default model (selected via providers.default()) was not being marked as visible in the model selector. This caused users to be unable to switch back to the default model after selecting a different one, because the visible() function hides models with valid release dates that are not the latest in their family. Add a createEffect that ensures the fallback model is always visible, matching the existing behavior for the configured model.
github-actions
bot
added
the
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
added
needs:issue
and removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #23247
Type of change
What does this PR do?
The model selector hides models with valid
release_datethat are not the latest in their family. The default model (fromproviders.default()) was never marked as visible, so it appeared as selected but was missing from the selector list. Switching away meant you couldn't switch back.Added a
createEffectthat marks the fallback model (configuredModel ?? recentModel ?? defaultModel) as visible, matching the existing behavior for the configured model.How did you verify your code works?
Started backend on :4097 and frontend dev server on :4444. Default model (glm-5.1) appeared in selector, switched to another model, switched back successfully.
Screenshots / recordings
Checklist