fix: add file cycling in multi-file permission prompt#23262
Open
nitishagar wants to merge 1 commit intoanomalyco:devfrom
Open
fix: add file cycling in multi-file permission prompt#23262nitishagar wants to merge 1 commit intoanomalyco:devfrom
nitishagar wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21914
Type of change
What does this PR do?
When
apply_patchedits multiple files, the permission prompt concatenates all diffs into one blob with no way to review individual files. The per-file data (metadata.files[]) was already being sent byapply_patchbut theEditBodycomponent ignored it, only reading the concatenatedmetadata.diffstring.This adds
[and]keybinds to cycle through files one at a time in the permission prompt:filesarray frommetadata.filesinEditBody]cycles to the next file,[cycles to the previous, with wrap-around[ ] fileshint in the prompt footer when in multi-file modefilesarray present, falls through to existing behavior)How did you verify your code works?
bun run typecheck— no new type errors (only pre-existing TS7006 from unresolved @opentui/solid types)filesarray → existing concatenated diff behavior)[/]keyboard handling follows the same pattern as existing cycling keybinds (agent_cycle, session_child_cycle)Screenshots / recordings
N/A — TUI change, needs manual testing with
"edit": "ask"permission config and a multi-file edit prompt.Checklist