feat(acp): plumb structured output format through _meta#23294
Closed
AbhiShake1 wants to merge 1 commit intoanomalyco:devfrom
Closed
feat(acp): plumb structured output format through _meta#23294AbhiShake1 wants to merge 1 commit intoanomalyco:devfrom
AbhiShake1 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Forwards the structured-output
formatoption through the ACPprompt()handler so ACP clients (IDEs, taskflow harnesses, other ACP-speaking tools) can request structured JSON output — the same capability the SDK gained in #8161.Before this change, the SDK honored
session.prompt({ format })but the ACP handler silently dropped it, leaving ACP clients unable to access structured output over the protocol. Motivated by the same use cases as #9320, #10456, and #5639.Changes
params._meta?.opencode?.formatinAgent.prompt(), validate it against the existingMessageV2.Formatzod schema (the same one feat: support claude agent SDK-style structured outputs in the OpenCode SDK #8161 added), and forward it tothis.sdk.session.prompt({ ..., format }).msg.structuredvalue back on thePromptResponse._metaas{ opencode: { structured } }when the model returned structured output._metaextension point with opencode's existing_meta.opencode.*namespacing convention (seebuildVariantMetaat the same file).How did you verify your code works?
bun run typecheck(tsgo --noEmit) — clean.bun test test/acp/agent-interface.test.ts— 1 pass, confirmingAgentstill implements theACPAgentinterface.promptrequest with_meta: { opencode: { format: { type: "json_schema", schema: { ... } } } }and observeresponse._meta.opencode.structuredcontaining the validated JSON.Notes
formatpayloads silently fall through to plain-text mode (safeParse + optional chaining) — matches the SDK'sformat.optional()contract./foo) don't consume structured output.