fix(tui): add ctrl+h as backspace alias for herdr/ConPTY compatibility#35545
Open
ddqd wants to merge 2 commits into
Open
fix(tui): add ctrl+h as backspace alias for herdr/ConPTY compatibility#35545ddqd wants to merge 2 commits into
ddqd wants to merge 2 commits into
Conversation
Inside herdr (Windows ConPTY multiplexer), physical Backspace arrives as 0x08 (ctrl+h / VT100 BS control character) rather than 0x7f. Adding ctrl+h to input_backspace makes Backspace work in herdr without conflicting with ctrl+backspace which is already bound to input_delete_word_backward. Fixes anomalyco#34878
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
ddqd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #34878
Type of change
What does this PR do?
Inside herdr (Windows ConPTY terminal multiplexer), physical Backspace
sends byte 0x08 (VT100 BS / ctrl+h) rather than 0x7f. OpenCode's
input_backspace only handled 0x7f and shift+backspace, so the 0x08 byte
matched nothing and Backspace silently did nothing.
Fix: add ctrl+h to input_backspace. No conflict with
input_delete_word_backward, which already owns ctrl+backspace.
How did you verify your code works?
Reproduced on Windows 11 + herdr + Windows Terminal: Backspace did
nothing. After the fix, Backspace deletes characters as expected.
Verified ctrl+backspace still triggers word deletion (no regression).
Screenshots / recordings
N/A — no visual change.
Checklist