Skip to content

fix(pty): upgrade bindings and honor packaging targets - #45809

Closed
Hona wants to merge 2 commits into
anomalyco:v2from
Hona:upgrade-pty
Closed

Hona wants to merge 2 commits into
anomalyco:v2from
Hona:upgrade-pty

Conversation

@Hona

@Hona Hona commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

Issue for this PR

No linked issue.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Updates @lydell/node-pty and all six platform packages to 1.2.0-beta.15.

Desktop builds now use OPENCODE_CLI_TARGET to select the PTY binding, sharing the existing sidecar target mapping. Windows ARM64 releases build on x64 hosts, so the previous host-based selection imported the wrong binding. Local builds still default to the host target. The shared mapping is separate from Bun-only build utilities so electron-vite can load it under Node.

How did you verify your code works?

  • Desktop bundle tests cover all six targets, the native fallback, and invalid targets.
  • Confirmed the Windows ARM64 regression test fails with the previous host-based selection.
  • One-time native Windows x64 and ARM64 checks passed under Node 24.19.0 and Electron 42.10.1. Both generic and platform-specific entry points load, spawn a PTY, and return the expected output and exit code. No workflow is added by this PR.
  • bun typecheck in packages/core and bun typecheck --force in packages/desktop pass.
  • Core PTY tests: 1 passed, 6 existing Windows skips. Desktop bundle tests: 12 passed.
  • Oxlint and Prettier checks pass for the changed build files.

Screenshots / recordings

Not applicable: dependency and packaging changes only.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Copilot AI lite review requested due to automatic review settings August 28, 2026 02:55
@Hona
Hona requested a review from Brendonovich as a code owner August 28, 2026 02:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants