fix(opencode): preserve V1 tool attachment filenames - #46160
Open
opencode-agent[bot] wants to merge 1 commit into
Open
fix(opencode): preserve V1 tool attachment filenames#46160opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix V1 tool attachment serialization for Responses providers, including Bedrock Mantle.
V1 emits attachments as legacy AI SDK
mediaparts. The SDK converts those tofile-datawithout retaining a filename, so a PDF tool result reaches Responses asfilename: "data". Replaying that attachment on later turns keeps sending the same extensionless filename, even when the latest tool only returns text.image-dataandfile-dataparts.attachment.pdffor unnamed PDFs, including existing session history.Scoped to the V1 serializer; no V2, provider-routing, dependency, or storage changes.
Validation
bun test test/session/message-v2.test.ts test/provider/transform.test.ts test/provider/amazon-bedrock.test.ts test/session/llm-native.test.ts --timeout 30000— 511 pass.bun typecheck— passed inpackages/opencode.git diff --check— passed.Request serialization was tested with intercepted transports, not live provider calls.
Requested by: @rekram1-node (Aiden via Slack)