test(tui): capture flushed Mini scrollback output - #46505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Mini monochrome scrollback test intermittently reports that its code block disappeared, receiving only
Next block. This predates preview tabs on v2 and has blocked unrelated PRs including #46496 and #46497.The test reads the renderer's private pending-output queue after asynchronous highlighting. A renderer frame can correctly flush the code block while completion is awaiting highlighting, leaving only the final paragraph in that queue. The output was emitted; the test inspected an incomplete observation of it.
What Changes
externalOutput.takeText()recorder, which preserves emitted output independently of queue consumption.Scope
One test file only. No production rendering changes, retries, timeout increases, or skipped tests. Other tests retain their existing queue assertions.
Verification
git diff --checkpassed.