fix(core): estimate context growth before compaction - #46543
Merged
Conversation
rekram1-node
marked this pull request as ready for review
September 1, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun typecheckinpackages/corepasses.bun test test/session-compaction.test.ts test/config/compaction.test.ts test/session-runner.test.tsinpackages/core: 192 passed.Before Merge
This changes when the existing check considers compaction necessary, not its retention policy. The no-usage fallback can trigger compaction before the first model request, but the existing serializer preserves attachment labels rather than their contents. That can remove unread attachment content. This draft keeps the estimator diff narrow while that retention decision is reviewed.