Skip to content

fix: stabilize OAuth tests and Windows npm staging - #46545

Open
rekram1-node wants to merge 5 commits into
v2from
fix-ci-tests
Open

fix: stabilize OAuth tests and Windows npm staging#46545
rekram1-node wants to merge 5 commits into
v2from
fix-ci-tests

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Keep the confirmed, limited CI fixes without expanding into Windows junction repair.

  • Assert TypeError for an invalid OAuth redirect instead of Bun-specific error wording.
  • Wait for the actual OpenAI OAuth method and configured agent permission rule before testing their behavior. Catalog reads no longer wait for plugin initialization.
  • Create registry fixture tarballs using a relative archive path so GNU tar does not interpret a Windows drive letter as a remote host.
  • Defer entrypoint resolution for successfully staged npm installs until after the staging directory is renamed. The pre-rename entrypoint was unused; avoiding it prevents Bun resolver handles from blocking the rename on Windows. Preserve metadata reads, revision comparison, requested subpaths, and the missing-node validation fallback.
  • Assert that Git installs return an entrypoint under their published package directory.

The later Windows junction-repair change has been reverted. No test skips, mutation retries, permission-policy changes, dependency changes, or schema-comment changes.

Validation

Bun 1.4.0 on macOS, for the retained changes:

  • Full core suite: 4,063 passed, 40 skipped.
  • Full server suite: 52 passed, 3 skipped.
  • Fetch suite repeated five times: 60 passed.
  • MCP OAuth suite: 6 passed.
  • Npm suite: 13 passed.
  • Util suite: 37 passed.
  • Core, server, and util typechecks passed.
  • git diff --check passed. Changed test files pass Prettier; existing formatting differences in util/npm.ts were left untouched.

Remaining Failures

The retained changes passed the Windows server suite and resolved the npm EPERM rename and tar-path errors. Two Windows Git dependency tests still fail because directory links point at the old staging location. Those are intentionally deferred.

The last run of the retained code also reported a Linux module-resolution error in the unchanged tool-edit test; that test and the full core suite pass locally. This PR does not claim all CI checks are green.

@rekram1-node rekram1-node changed the title test: fix OAuth assertions and server readiness fix: resolve OAuth readiness and Windows npm CI failures Sep 1, 2026
@rekram1-node rekram1-node changed the title fix: resolve OAuth readiness and Windows npm CI failures fix: stabilize OAuth tests and Windows npm staging Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant