Repository navigation
fix(opencode): answer a failed TUI worker request instead of hanging - #54936
Merged
Merged
Conversation
A method behind the TUI worker's RPC channel that threw never got a reply, so the caller's promise never settled. The TUI waits on that channel before it draws anything, so for example `opencode --port 4096` with port 4096 already taken stayed on a blank screen forever. The worker now answers a failed request with the error's message, or its cause's when it has none (a taken port fails with an empty ServeError whose cause names the port), and the call rejects with it, so opencode exits with that message.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Nowaker
added a commit
to Nowaker/opencode
that referenced
this pull request
Oct 12, 2026
A new feature record covers the TUI worker's error replies (c50b736, upstream issue anomalyco#54934 and PR anomalyco#54936 against v1). The session maintenance record gains the bounded write-lock retry at startup (22e6326) in its safety contract and timeline. The 2026-10-12 session record has the cause, the reproduction on vt-243 against vt-248 with several opencode processes starting on a locked database, and the installs on both hosts. AI-Tool: opencode 1.18.34-vt-128-907b3bc518 AI-Model: anthropic/claude-opus-5-5 AI-Variant: max AI-Platform: linux AI-Harness: Vibeterm a2d1757 AI-Session-ID: ses_eebf9a83fffeIQQwW9gVFo5jaO
Contributor
|
thanks! |
jlongster
enabled auto-merge (squash)
October 27, 2026 17:01
rekram1-node
disabled auto-merge
October 27, 2026 19:02
This was referenced Oct 28, 2026
This was referenced Oct 29, 2026
Nowaker
added a commit
to Nowaker/opencode
that referenced
this pull request
Nov 2, 2026
Merge github/v1 at 006d837 ("sync release versions for v1.19.5"), whose tree equals the v1.19.5 tag. dev-nowaker already carries the approved mirror-reconciliation merge 74a093f and is pushed to both remotes, so a rebase would rewrite published history; a merge keeps both pushes fast-forward. The merge-base with github/v1 becomes 006d837, so build.sh stamps 1.19.5-vt-<seq>-006d837c50. Conflicts: - cli/cmd/tui.ts: take upstream's failed-check catch, keep reporting InstallationBaseVersion as current. - installation/index.ts: keep the stamped install method; drop ReleaseType with upstream's getReleaseType removal. Upstream's new latest() compares against the base version, because a -vt- prerelease stamp would make the fork's own base release look like an update. - installation.test.ts: keep the stamped-method test's path import; latest() assertions expect InstallationBaseVersion. - util/rpc.ts: upstream landed part of the TUI worker error reply (anomalyco#54936). Take its reply/serialize .catch and failureMessage, keep the fork's ready handshake, queued requests and worker-failure rejection. - tui sidebar.tsx: keep the pinnable title() and drop the share URL line with upstream's session sharing removal. AI-Tool: opencode 1.19.0-vt-384-dfb56f76c7 AI-Model: anthropic/claude-opus-5-5 AI-Variant: high AI-Platform: linux AI-Harness: Vibeterm 9f4981e2b66 AI-Session-ID: ses_e6683c468ffewy5J1dk7eU3NGi
Nowaker
added a commit
to Nowaker/opencode
that referenced
this pull request
Nov 2, 2026
Session record for merging github/v1 006d837 (v1.19.5) as 6b5b489: why a merge instead of a rebase, the upstream changes that touch fork seams, the five conflict resolutions, pre-existing test failures confirmed on the old tip, Bun 1.4.4, and both hosts' gated builds and installed-binary smoke at 1.19.5-vt-386-006d837c50. Timeline rows and upstream checkpoints for every feature it changed or re-verified; anomalyco#54936 is now merged upstream. AI-Tool: opencode 1.19.0-vt-384-dfb56f76c7 AI-Model: anthropic/claude-opus-5-5 AI-Variant: high AI-Platform: linux AI-Harness: Vibeterm 9f4981e2b66 AI-Session-ID: ses_e6683c468ffewy5J1dk7eU3NGi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #54934
Type of change
What does this PR do?
The TUI talks to its server worker over a small RPC channel and waits on it before it draws anything, for example to start the listener for
--port. When the worker's handler threw,Rpc.listennever posted a reply (the worker'sunhandledRejectionhandler swallows the error), so the TUI'sclient.call()never settled. Withopencode --port 4096and the port already taken, that is a blank terminal forever, with no hint why.Now
Rpc.listenanswers a failed request with the error's message andRpc.clientrejects the pending call with it. The failure reaches the TUI's existing error handling, and opencode exits withFailed to start server. Is port 4096 in use?.Server.listenrejects with aServeErrorthat has no message of its own and names the port in its cause, so when an error has no message, the cause's is sent instead.Related: #34981 and #42885 cover a worker that dies with calls pending. This covers a worker that stays up but whose handler throws.
How did you verify your code works?
test/util/rpc.test.tsdrives a real worker whose methods return, throw, reject, and throw with only a cause. Onv1without the change, 3 of the 4 tests fail because those calls get no reply; with it, all 4 pass.opencode --port <port>while another process holds the port: before, the screen is still blank 20 s later; after, opencode exits with code 1 and the message above.bun typecheckinpackages/opencodeis clean, andtest/cli/tui/thread.test.tspasses.Screenshots / recordings
Not a UI change; the visible difference is the error message above.
Checklist
This PR is AI generated, but under direct supervision and on request of @Nowaker.