Repository navigation
fix(app): make the browser tests pass after the beta merge - #59160
Conversation
Active message transitions forced visibility: visible, so Rewind, Fork, Move to queue and Delete stayed exposed (and focusable) in the hidden footer of a folded run message, beside the copy shown next to its bubble. Active transitions now inherit visibility. Unquarantines the session-queue tests that caught it.
- Size composer suggestion menus for their 6px padding (#58418 changed it from 8px), so history shows no clipped row under Search. - Isolate the session story's stacking like the app's chat panel, so the web search provider menu opens above the dock. - Expect the virtualizer's 82px tail (#57273, #57883) in the offset-only reconnect case. - Pause the clock and wait for fonts before measuring the activity panel, which a late Inter swap widened on Windows. - Remove the @quarantine tags from the fixed tests.
…-state cases - Expect the session directory on file search requests; the mock forwards it since #57725. - Scroll a windowed file view to its end before reading the draft; text files over 200 lines window since #57551. - Wait for side-panel focus before Ctrl+W; Close Tab follows focus since #57935. - Wait for the file tree's scroll suppression to clear before clicking a row, so Playwright's retry scroll does not move the position under test.
- Notices: assert the v2 faint text token from #58115. - Revealed shell: re-target TanStack on every anchor pin so its exact landing cannot undo a 1px compensation. - Activity menu: list blocking subagents before backgrounded ones again (lost in 3dca04a). - Markdown tables: keep header cells selectable so quotes and copies keep the header row (#58372). - Live Thinking: wait for the busy status before jumping the fake clock, which fires in-flight request timeouts.
SessionHeaderLayout read its JSX actions prop in both the Show condition and its children, so it rendered the actions twice. The detached copy's Find input took the search controller's input ref, and Mod+F focused it instead of the visible field. Also update the workspace-switch test for the header's project label.
Count only the activity capsule's own animation, not its spinner's loop. Move the touch-out-of-view drag to a row that leaves the virtual window now that the timeline scrolls under the composer, and anchor on a row that stays in view below the session location bar. Disable the bubble's colour transition while marking prompts for the frame reader.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
The change looks sound. I reviewed the diff and ran the app's session unit tests (test-browser/session-background.test.ts and src/session, all passing) and tsc -b for packages/app (clean). The e2e tsc errors are the same on the base. I couldn't run the Playwright component or e2e suites here because Chromium won't start (missing system library), so CI's e2e (linux)/e2e (windows) runs are the real check for this one.
The app fixes are small and in the right place: the header renders its actions once from the Show callback, folded footers inherit hidden, blocking subagents are listed before background ones, and the composer padding matches the CSS. The changed tests address the timing causes (clock pause, document.fonts.ready, waiting for scrolling to settle, transitions off) rather than adding sleeps.
Public API: unchanged (app UI and tests only).
There was a problem hiding this comment.
The new commit changes only the reread test and is fine. The reopened tab no longer has to start at the top: the test waits until the code view can scroll, then scrolls to the end, and it still checks the start position on the first open. I couldn't run the e2e suite here because Chromium won't start in this sandbox, so CI is the real check. Public API: unchanged.
Follow-up to the beta merge (
be315b1db8). Beta skipped its failing browser tests with@quarantine; dev runs them, soe2e (linux)ande2e (windows)went red. This fixes every one and clears the quarantine list.App fixes
session-ui/.../message-part.css)visibility: visible, so a folded message's hidden footer still exposed a second Rewind, Fork, Move to queue and Delete to keyboard and screen readersvisibility: inherit; drops the timestamp-only workaroundsession-identity-header.tsx)<Show>read theactionsJSX prop twice, so the Find bar and extension slot rendered twice; Mod+F focused the detached copyShowcallback valuerequests/background.ts)timeline/virtualizer.tsx)session-ui/.../markdown.css)user-select: noneon header cells: a drag from a header selected nothing, and quoting lost the header rowcomposer/editor/editor.tsx)6Stale tests, updated to beta's intended behaviour
directory; files over 200 lines are windowed; Ctrl+W closes a side-panel tab only once focus is in the panel; wait for the tree to stop scrolling before clicking.h1.Flakes fixed at the cause
document.fonts.ready.QUARANTINE.mdnow lists no tests. Its process text is unchanged.Visual