Repository navigation
fix(app): keep location shortcut working after tooltip hover - #59680
Merged
Merged
Conversation
There was a problem hiding this comment.
The fix works. I reproduced the stuck location with the new e2e test against the base view.tsx: after hovering the icon, the shortcut leaves the location on local. With this change the test passes, and it passed 8 more times in a row with no retries. The full new-session.spec.ts suite passes (26/26 on Linux, including the caret-position test), and tsc -b in packages/app is clean.
Using a keyed Show is a sound, local fix: the path row and its tooltips are rebuilt when the path changes, so an open tooltip can't read an outdated value. The test is short and doesn't rely on fixed waits.
Public API: unchanged (web app UI only).
No blocking concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Showso an open tooltip cannot read a stale accessor when switching to a new worktree.Verification
Also:is appended instead of prepended on local macOS).Screenshots
Same shortcut after hovering the local-location icon:
Before
The tooltip remains and the location is stuck on local.
After
The tooltip closes and the location switches to New worktree.