Repository navigation
fix(process-daemon): poll every 25 ms on Windows - #59702
Merged
Merged
Conversation
jlongster
force-pushed
the
daemon-poll-loop
branch
from
October 27, 2026 19:55
4490c9c to
3aaa646
Compare
jlongster
force-pushed
the
daemon-windows-poll
branch
from
October 27, 2026 19:55
bf8b850 to
327e9e5
Compare
jlongster
force-pushed
the
daemon-poll-loop
branch
from
October 27, 2026 20:07
3aaa646 to
c7d57b8
Compare
jlongster
force-pushed
the
daemon-windows-poll
branch
from
October 27, 2026 20:07
327e9e5 to
8e0d424
Compare
jlongster
force-pushed
the
daemon-poll-loop
branch
from
October 27, 2026 22:22
c7d57b8 to
870a490
Compare
jlongster
force-pushed
the
daemon-windows-poll
branch
from
October 27, 2026 22:22
8e0d424 to
4457371
Compare
jlongster
force-pushed
the
daemon-poll-loop
branch
from
October 27, 2026 22:33
870a490 to
aa3190b
Compare
jlongster
force-pushed
the
daemon-windows-poll
branch
from
October 27, 2026 22:33
4457371 to
99e3991
Compare
jlongster
force-pushed
the
daemon-poll-loop
branch
from
October 28, 2026 00:52
aa3190b to
275ff87
Compare
jlongster
force-pushed
the
daemon-windows-poll
branch
from
October 28, 2026 00:52
99e3991 to
170281b
Compare
jlongster
force-pushed
the
daemon-windows-poll
branch
from
October 28, 2026 01:11
170281b to
baa91d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from anomalyco/opencode-pty#33. Part of the stack for anomalyco/opencode-pty#25. Builds directly on
dev(#59701 merged), no prerequisite.Issue for this PR
Related to anomalyco/opencode-pty#25
Type of change
What does this PR do?
Listener::waitstub inpackages/process-daemon/src/transport/windows.rsnow sleeps up to 25 ms instead of 10 ms (POLL_INTERVAL).packages/process-daemon/src/service/windows.rsnow polls every 25 ms instead of 10 ms (EXIT_POLL_INTERVAL).transport/mod.rsdoc, and the code comments now say 25 ms.waitcallWaitForMultipleObjectson the pending connect event plus a stop event, and have each terminal block inWaitForSingleObjecton its process handle.src/daemon/server.rstiming tests are Unix-only, so no test needed changing.The commit applied unchanged after rebasing the stack onto
dev(identical patch ID to the opencode-pty commit).How did you verify your code works?
Port validation (macOS arm64, Rust 1.90.0, in
packages/process-daemon), this is the stack tip:cargo fmt --checkandcargo clippy --locked --all-targets --all-features -- -D warningspass.cargo test --locked --lib --test service --test runtime --test ownership --test rows --test ghostty-effects(lib 65, ghostty-effects 5, ownership 8, rows 1, runtime 8 + 1 ignored, service 9).cargo test --locked --lib daemon::server, 13 tests) passed 3 runs in a row.-D warningspasses forx86_64-pc-windows-msvcandx86_64-unknown-linux-gnu(--all-targets --all-features, ghostty-vt link libs stubbed). Native Windows and Linux rely on CI.Screenshots / recordings
N/A, internal daemon change.
Checklist