Repository navigation
release: v2.2.1 - #60113
release: v2.2.1#60113
Conversation
There was a problem hiding this comment.
The version bumps and changelog entry are as expected, with one exception: packages/process-daemon/npm/package.json (@opencode/pty) has its own release, but the release script bumped it from 0.3.2 to 2.2.1 along with everything else (see inline comment).
I checked the version changes in each file and the release scripts; there is nothing to run. The public API is unchanged: version numbers only.
The cause is .github/release/tag-release.sh, which overwrites the version in every tracked package.json. It should skip packages/process-daemon/ (for example with ':!packages/process-daemon/**' in the git ls-files pathspec), or later releases will bump it again.
| { | ||
| "name": "@opencode/pty", | ||
| "version": "0.3.2", | ||
| "version": "2.2.1", |
There was a problem hiding this comment.
@opencode/pty is released on its own (process-daemon-v* tags) and was at 0.3.2. Its optionalDependencies and packages/process-daemon/Cargo.toml are still at 0.3.2. Because this PR touches npm/**, the Validate tag step in release-process-daemon.yml runs, and it requires the npm version to equal the Cargo version and every platform dependency to equal the package version, so it should fail here and on dev after merge. Please revert this file to 0.3.2, and make tag-release.sh skip packages/process-daemon/ so the next release doesn't bump it again.
There was a problem hiding this comment.
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
There was a problem hiding this comment.
The new commit sets @opencode/pty back to 0.3.2. The file is now the same as on dev, which keeps the process-daemon release check consistent. The public API is unchanged: version numbers only.
The root cause is still in .github/release/tag-release.sh: it overwrites the version in every tracked package.json, so the next release will bump this package again unless the script skips packages/process-daemon/. That fix belongs in a separate PR to dev.
Brings the versions and changelog of the published
v2.2.1release back todev. Thev2.2.1tag points at this commit.