Skip to content

fix(app): stop :has() rules restyling every ancestor on DOM insertion #60521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 2 commits into from
Oct 30, 2026
+15 −4
Merged

fix(app): stop :has() rules restyling every ancestor on DOM insertion #60521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ad9bab
fix(app): stop :has() rules restyling every ancestor on DOM insertion
Hona Oct 30, 2026
8206711
refactor(ui): mark a closing preview from its existing close effect
Hona Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/app/src/settings/settings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,16 +846,22 @@
justify-content: flex-end;
}

[data-slot="settings-row-control"] > div:has([data-component="switch"]),
/* The :has() belongs on the control, not on its div. Chromium checks a div:has() subject against every div in the
document and flags each one, then restyles a flagged div whenever an element is inserted anywhere beneath it, which
is every ancestor of a streaming answer. */
[data-slot="settings-row-control"]:has(> div [data-component="switch"]) > div,
[data-slot="settings-row-control"] > [data-component="switch"] {
display: inline-flex;
align-items: center;
padding: 4px;
}

[data-component="settings-list"][data-variant="catalog"]
[data-slot="settings-row-control"]:has(> div [data-component="switch"])
> div,
[data-component="settings-list"][data-variant="catalog"]
[data-slot="settings-row-control"]
> :is(div:has([data-component="switch"]), [data-component="switch"]) {
> [data-component="switch"] {
padding: 0;
}

Expand Down
5 changes: 3 additions & 2 deletions packages/ui/src/components/image-preview.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,9 @@
}

/* A modal Kobalte dialog turns the body's pointer events off and only restores them when its content unmounts, which
the closing flight above holds back; the page takes clicks again as soon as the close starts. */
body:has([data-component="image-preview"] [data-slot="image-preview-content"][data-closed]) {
the closing flight above holds back; the page takes clicks again as soon as the close starts. The preview marks the
body itself: a body:has() rule made Chromium restyle the body on every DOM insertion anywhere in the page. */
body[data-image-preview-closing] {
pointer-events: auto !important;
}

Expand Down
4 changes: 4 additions & 0 deletions packages/ui/src/components/image-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,12 +405,16 @@ export function ImagePreview(props: ImagePreviewProps) {
settle()
showOrigin()
giveBack()
document.body.removeAttribute("data-image-preview-closing")
})

createEffect(
on(
() => dialog.isOpen(),
(open) => {
// See image-preview.css: the body takes clicks again while the closing flight holds the dialog mounted.
document.body.toggleAttribute("data-image-preview-closing", !open)

if (!open) dismiss()
},
{ defer: true },
Expand Down
Loading