Add action/session level MCP interaction logging#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
action_id,session_id) at the tool-invocation boundary and forward them to downstream services.Description
MCPServer.call_toolnow generatesaction_id/session_id(and accepts caller-providedsession_id/source) and returns them on everyToolCallResponse.app/domains/mcp_server/server.pyfor tool invocation events (started,not_found,missing_argument,succeeded,failed) and endpoint-level logs for/mcp/toolsand/mcp/resourcesincluding source IP and path metadata.app/domains/mcp_server/client.pyviamcp_outbound_request,mcp_outbound_response, andmcp_outbound_error, and forwardX-MCP-Action-IDandX-MCP-Session-IDon requests.action_id/session_idand update docs (README.md,ARCHITECTURE.md,AI_CHANGE_CHECKLIST.md) to document the traceability behavior.Testing
python -m pytest tests/unit/test_mcp_client_unit.py tests/unit/test_mcp_server_unit.py -qand all tests passed (9 passed).make lintandmake typecheckbut the environment is missing local virtualenv tools (.venv/bin/ruff,.venv/bin/mypy) so these targets could not run to completion.make audit-securityandmake testbut these failed in the current environment due to missingdockerand.venv/bin/pytestrespectively, which are environmental blockers rather than code failures.Codex Task