fix: harden Windows launcher shutdown for missing WMI process metadata#327
Open
takuto-NA wants to merge 2 commits intoansys:mainfrom
Open
fix: harden Windows launcher shutdown for missing WMI process metadata#327takuto-NA wants to merge 2 commits intoansys:mainfrom
takuto-NA wants to merge 2 commits intoansys:mainfrom
Conversation
Avoid secondary shutdown failures when WMI process objects disappear or their property getters raise during launcher exit. Add launcher tests that reproduce missing WMI process metadata and runtime errors from ProcessId and pid lookups. Made-with: Cursor:
Keep child process shutdown messages accurate when WMI metadata is unavailable by reserving fallback process ids for the launched process only. Made-with: Cursor:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launcher.exit()Test plan
python -m pytest tests/ -v --tb=shortpython -m pytest tests/test_workbench_launcher.py tests/test_launch_workbench.py -v --tb=short