fix: use portable shebangs in shell scripts #15877
Open
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardcoded #!/bin/bash shebang fails on NixOS and other systems where bash is not located at /bin/bash (e.g., NixOS has bash at /run/current-system/sw/bin/bash). Using #!/usr/bin/env bash is the portable POSIX standard that finds bash via PATH, working across NixOS, Guix, macOS, FreeBSD, and standard Linux distributions. Files updated: - .devcontainer/init-firewall.sh - plugins/plugin-dev/skills/*/scripts/*.sh - plugins/plugin-dev/skills/*/examples/*.sh - plugins/ralph-wiggum/hooks/stop-hook.sh - plugins/ralph-wiggum/scripts/setup-ralph-loop.sh Also updated hook-linter.sh to recommend the portable shebang.
Author
|
@amorriscode sorry for the ping, but I just saw that you updated the ralph plugin, would be great to get this PR reviewed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12880
Fixes #15876
Summary
Change all shebangs from
#!/bin/bashto#!/usr/bin/env bash.This is the portable POSIX standard that finds bash via PATH, working on NixOS, Guix, macOS, FreeBSD, and standard Linux distributions.
Changes
Updated 13 shell scripts across:
.devcontainer/init-firewall.shplugins/plugin-dev/skills/*/scripts/*.shplugins/plugin-dev/skills/*/examples/*.shplugins/ralph-wiggum/hooks/stop-hook.shplugins/ralph-wiggum/scripts/setup-ralph-loop.shAlso updated
hook-linter.shto recommend the portable shebang in its error message.Testing
Tested locally on NixOS - all scripts now work correctly.