Fix SSE keepalive to use wall-clock timer, not progress callback#227
Open
ridhinva wants to merge 1 commit into
Open
Fix SSE keepalive to use wall-clock timer, not progress callback#227ridhinva wants to merge 1 commit into
ridhinva wants to merge 1 commit into
Conversation
The SSE keepalive comment () was emitted from inside the server_prefill_progress callback, which only fires on chunk boundaries. When a single prefill chunk stalls internally for longer than the client's idle timeout, no progress callback fires, no keepalive is sent, and the client eventually drops the socket. Fix: add a background pthread () that sends keepalive comments on a 5-second wall-clock timer independent of progress events. The thread is started before ds4_session_sync() and joined after it completes (or fails), covering both the main prefill path (generate_job) and the tool-checkpoint rebuild path (canonicalize_tool_checkpoint). Fixes antirez#222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSE keepalive comment () was emitted from inside the server_prefill_progress callback, which only fires on chunk boundaries. When a single prefill chunk stalls internally for longer than the client's idle timeout, no progress callback fires, no keepalive is sent, and the client eventually drops the socket.
Fix: add a background pthread () that sends keepalive comments on a 5-second wall-clock timer independent of progress events. The thread is started before ds4_session_sync() and joined after it completes (or fails), covering both the main prefill path (generate_job) and the tool-checkpoint rebuild path (canonicalize_tool_checkpoint).
Fixes #222