agent: add --chdir working-directory option#232
Open
gmontana wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
--chdir DIRtods4-agent, matching the existingds4-serverworking-directory option. This lets external launchers start the native agent from another current directory while still resolving relative runtime assets, includingmetal/*.metal, from the selected project/install tree.Also document the flag in the native-agent README section.
Fixes #221
Validation
git diff --checkmake ds4-agent./ds4-agent --help./ds4-agent --chdir /tmp/ds4-agent-chdir-does-not-exist --non-interactiveexits with the expected chdir error./ds4_test --server