Conversation
* added void return type to put() * deleted code-tag in description in docblock
|
@HermanPeeren I'll set up a workflow for running automated tests and code style checks over the next days, and then I'm going to come back to this, ok? |
src/Tree/ParseTreeProperty.php
Outdated
| { | ||
| $value = $this->get($node); | ||
| $this->storage->detach($node); | ||
| return $value; |
There was a problem hiding this comment.
Please put a line before the return statement
src/Tree/ParseTreeProperty.php
Outdated
| */ | ||
| public function removeFrom(ParseTree $node) | ||
| { | ||
| $value = $this->get($node); |
There was a problem hiding this comment.
The indentation should be 4 chars long
src/Tree/ParseTreeProperty.php
Outdated
| public function get(ParseTree $node) | ||
| { | ||
| $value = null; | ||
| if ($this->storage->contains($node)) { |
src/Tree/ParseTreeProperty.php
Outdated
| if ($this->storage->contains($node)) { | ||
| $value = $this->storage->offsetGet($node); | ||
| } | ||
| return $value; |
src/Tree/ParseTreeProperty.php
Outdated
| */ | ||
| class ParseTreeProperty | ||
| { | ||
| protected $storage; |
There was a problem hiding this comment.
Yep. It was private first, but I changed it to protected to be abele to use it in the drived class... which is not a good idea. Change it back. Thanks.
|
OK, thanks!
|
…ult from code review by @marcospassos.
|
@HermanPeeren we follow the style specified here. Currently, the library is covered by functional tests. Unit tests and performance tweaks are great contributions at the moment. |
Haha, I cou;ld have seen that... have to look better. Will use that in PHPstorm. Thanks for reviewing, @marcospassos ! Very welcome! |
|
Hi @HermanPeeren! Are you still interested in working on this PR? |
2 participants
fixes #7