Skip to content

fix LSP document navigation on Windows - #36

Closed
andreisfedotov wants to merge 2 commits into
mainfrom
lsp-windows
Closed

fix LSP document navigation on Windows#36
andreisfedotov wants to merge 2 commits into
mainfrom
lsp-windows

Conversation

@andreisfedotov

Copy link
Copy Markdown
Member

checked for C# and TypeScript on Windows and Mac machines

@andreisfedotov
andreisfedotov requested a review from vipmax August 20, 2026 11:09
@andreisfedotov andreisfedotov self-assigned this Aug 20, 2026
@andreisfedotov andreisfedotov added bug Something isn't working enhancement New feature or request labels Aug 20, 2026
Comment thread anycode/hooks/useEditors.ts Outdated
return rawPath;
return /^\/[A-Za-z]:\//.test(rawPath)
? rawPath.slice(1)
: rawPath;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use function from utils.ts

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it hasn't same function but I moved it there and used in other files as well :D

@vipmax

vipmax commented Sep 1, 2026

Copy link
Copy Markdown
Member

Thanks for the PR and contribution!

We have integrated and refined the core fixes (the didOpen deduplication, the uriToFilePath utility across components, and definition routing via openFile), and added unit tests in commit 9689bf3 (crediting you as co-author).

We decided not to include the projectInitialization logic to avoid hardcoding timeouts and server-specific notifications in the generic LSP client.

Closing this PR. Thanks again for your work! 🚀

@vipmax vipmax closed this Sep 1, 2026
vipmax added a commit that referenced this pull request Sep 1, 2026
- Add uriToFilePath to correctly parse Windows file:// URIs
- Deduplicate textDocument/didOpen notifications
- Route definition navigation through openFile
- Add vitest and cargo tests

Refs #36
Co-authored-by: Andrei Fedotov <drewfedotov@gmail.com>
@andreisfedotov
andreisfedotov deleted the lsp-windows branch September 1, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants