docs: sync per-project-config.md with shipped single-blob implementation#200
Open
neversettle17-101 wants to merge 2 commits into
Open
docs: sync per-project-config.md with shipped single-blob implementation#200neversettle17-101 wants to merge 2 commits into
neversettle17-101 wants to merge 2 commits into
Conversation
Rewrite the Storage strategy, Surface, Sequencing sections and the Field
catalog table so they match what shipped: the whole ProjectConfig is one
projects.config JSON blob, set via a single PUT /projects/{id}/config and
ao project set-config. The originally proposed per-field columns, env
project_env child table, and per-group routes (PUT .../agent-config, .../env)
are marked superseded/future. Correct the CLI surface (no ao project env set;
env is --env KEY=VALUE on set-config). Typed model block and the typed-over-map
principle preserved.
Closes #199
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
neversettle17-101 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #199. Docs-only:
docs/design/per-project-config.mdhad drifted from the shipped implementation. The status header already described reality (singleprojects.configJSON blob, singlePUT /projects/{id}/config,ao project set-config), but the Storage strategy, Surface, Sequencing sections and the Field catalog table still described the originally proposed per-field columns / child tables / per-group routes.Changes (docs only, no code touched)
Storage today/Targetcolumns toHome/Status, mapping each shipped field to its key in theconfigJSON blob and marking unmodeled fields (rules, tracker, scm, opencode strategy, reactions) asnot modeled.projects.configTEXTcolumn (migration0008_add_project_config.sql). The per-column /project_envchild-table plan is flagged as superseded, citing the migration comment.PUT /projects/{id}/configroute (config also accepted onPOST /projects) and the actualao project set-configflags. Corrected the CLI: there is noao project env setsubcommand — env is--env KEY=VALUEonset-config.backend/internal/domain/projectconfig.go), the "typed over map" principle, and the Field catalog left columns.Audit grounding
backend/internal/domain/projectconfig.go— typedProjectConfig, one JSON blob per project.backend/internal/storage/sqlite/migrations/0008_add_project_config.sql— singleconfig TEXTcolumn.backend/internal/httpd/controllers/projects.go—PUT /projects/{id}/config.backend/internal/cli/project.go—set-configflags.Note for follow-up
No code/doc intent disagreements found that warrant a code change — the implementation is self-consistent; only the doc prose lagged.
🤖 Generated with Claude Code