Repository navigation
Reject database snapshots for a replaced source selection - #165
Closed
dayebishouji wants to merge 1 commit into
Closed
dayebishouji wants to merge 1 commit into
dayebishouji wants to merge 1 commit into
Conversation
alkor2000
pushed a commit
that referenced
this pull request
Nov 3, 2026
Replacing a database source could leave a valid saved snapshot of its previous selection. inventory and evidence bundle answered from it, and baseline accept wrote it as the Baseline under the current source ID. All three commands now compare the saved manifest with the current source declaration first, through the selection comparison Database Cognition already uses, and refuse a mismatch with database_snapshot_selection_mismatch and an instruction to take a new snapshot; a refused accept writes no Baseline. A CLI regression replaces a SQLite path, checks the three refusals and the absent Baseline, and recovers after a fresh snapshot. Ported from the contributor's branch onto the 0.2.0 line, excluding the governance assets, which the line re-authors. Closes #165 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alkor2000
pushed a commit
that referenced
this pull request
Nov 3, 2026
- CHANGELOG: one Unreleased bullet each for the deletion-only delta proof (#164) and the replaced-selection snapshot refusal (#165), both by dayebishouji. - The zh-CN database.error.snapshot_selection message follows its neighbours: "数据库source %s", "已保存Snapshot", no spaces around ASCII. - The delivery contract's paragraph that #164 extended is rewrapped to the file's width; no word changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Replacing a database source can leave a valid saved snapshot for its previous selection. The inventory and evidence bundle commands could use that snapshot, and baseline acceptance could write it under the current source ID.
Change
database_snapshot_selection_mismatchwith instructions to collect a new snapshot.The check reuses the selection comparison already used by Database Cognition.