Skip to content

Conversation

@richochetclementine1315

Changed the cli commands from camelCase to kebab-case as mention in #5463

Signed-off-by: Mrinmoy_1315 <mrinmoymatilal1315@gmail.com>
@DomGarguilo DomGarguilo linked an issue May 21, 2025 that may be closed by this pull request
@DomGarguilo
Copy link
Member

It looks like the ticket was suggesting that this change should happen in the 2.1 branch. This PR is against the main branch so will need to be switched.

@DomGarguilo DomGarguilo added this to the 2.1.4 milestone May 21, 2025
@ctubbsii
Copy link
Member

It looks like the ticket was suggesting that this change should happen in the 2.1 branch. This PR is against the main branch so will need to be switched.

I think it's okay if it happens in main instead. It's not high priority, and it would be easier to just make the change in main. However, I do think that the conflicts need to be resolved with the main branch, and that there should be aliases for the old names that are deprecated (warn and proceed), so it's easy to migrate from 2.1 to 4.0.

@richochetclementine1315
Copy link
Author

@ctubbsii is it fine now can u pls chk ones and give ur feedback?? :)

@dlmarion
Copy link
Contributor

@richochetclementine1315 - looks like you have a code formatting issue. Suggest running mvn clean package and committing the formatting change.

@ctubbsii ctubbsii modified the milestones: 2.1.4, 4.0.0 May 28, 2025
@ctubbsii
Copy link
Member

@richochetclementine1315 - looks like you have a code formatting issue. Suggest running mvn clean package and committing the formatting change.

The code doesn't compile:

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:[560,9] 'else' without 'if'

It also seems to delete a few commands without replacement, and it will need to have the old names still exist, as deprecated, if we are to merge this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace admin signalShutdown with a better name

4 participants