consolidate InfoViewer and PropEditor #6458
Open
ArbaazKhan1 wants to merge 2 commits into
Open
Conversation
DomGarguilo
requested changes
Jul 8, 2026
Comment on lines
+137
to
+138
| v.tablesOpt.addAll(opts.tablesOpt); | ||
| v.namespacesOpt.addAll(opts.namespacesOpt); |
Member
There was a problem hiding this comment.
--get advertises the ability to accept --table and --namespace as well but only the plural tables and namespaces opts are copied.
Contributor
Author
There was a problem hiding this comment.
The singular --namespace / --table and plural --nampespaces / --tables are intentionally separate. They are intended to serve the different modes. The singular flags are meant to display a singular Zk scope for --set and --delete or default display, while the plural is used for filtering multi-scope ZK reports via --get.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #6428
Created a new
zk propscommand to consolidate ZooKeeper property inspection and editing. Both legacy commands are depreciated but remain and functional for backwards compatibility. The newzk propscore sub-commands operate as such: