Exclude Cassandra for Python 3.12#38050
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 11, 2024
Merged
Conversation
We need to exclude Cassandra separately, in order to make sure that cassandra drivers are not installed in the Python 3.12 image when preparing it from the main branch. Generally speaking the dependencies are cached from the main branch when image is built, which means that the resulting image will still have cassandra driver even if we remove it in final pyproject.toml. The way how to get rid of it is two fold: 1) add the exclusion to main 2) after it is merged, increase the EPOCH number in the Dockerfile.ci in the PR that adds Python 3.12 compatibility
potiuk
requested review from
Taragolis,
eladkal,
ephraimbuddy,
hussein-awala,
josh-fell and
pankajkoti
Member
Author
|
This one MUST be merged before we do final check on #36755 - otherwise cached image will still contain cassandra driver. |
hussein-awala
approved these changes
Mar 11, 2024
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
We need to exclude Cassandra separately, in order to make sure that cassandra drivers are not installed in the Python 3.12 image when preparing it from the main branch. Generally speaking the dependencies are cached from the main branch when image is built, which means that the resulting image will still have cassandra driver even if we remove it in final pyproject.toml. The way how to get rid of it is two fold: 1) add the exclusion to main 2) after it is merged, increase the EPOCH number in the Dockerfile.ci in the PR that adds Python 3.12 compatibility
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to exclude Cassandra separately, in order to make sure that cassandra drivers are not installed in the Python 3.12 image when preparing it from the main branch.
Generally speaking the dependencies are cached from the main branch when image is built, which means that the resulting image will still have cassandra driver even if we remove it in final pyproject.toml.
The way how to get rid of it is two fold:
in the PR that adds Python 3.12 compatibility
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.