Skip to content

Fix: add check for xcom permission when result is specified for DagRun wait endpoint#64415

Merged
pierrejeambrun merged 1 commit intoapache:mainfrom
sjyangkevin:fix-dag-run-wait-endpoint-xcom
Mar 30, 2026
Merged

Fix: add check for xcom permission when result is specified for DagRun wait endpoint#64415
pierrejeambrun merged 1 commit intoapache:mainfrom
sjyangkevin:fix-dag-run-wait-endpoint-xcom

Conversation

@sjyangkevin
Copy link
Copy Markdown
Contributor

@sjyangkevin sjyangkevin commented Mar 29, 2026

Why

XCom access is governed by RESOURCE_XCOM permissions but the experiment Wait API endpoint returns XCom results with only DagRun read permission. Enhance the permission check.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code Opus 4.6] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 29, 2026
@sjyangkevin sjyangkevin force-pushed the fix-dag-run-wait-endpoint-xcom branch from dfe5147 to 1e086cf Compare March 29, 2026 22:12
@sjyangkevin sjyangkevin marked this pull request as ready for review March 30, 2026 01:27
@sjyangkevin sjyangkevin force-pushed the fix-dag-run-wait-endpoint-xcom branch from 1e086cf to 45e043e Compare March 30, 2026 01:27
Copy link
Copy Markdown
Contributor

@henry3260 henry3260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! One minor concern

@sjyangkevin sjyangkevin force-pushed the fix-dag-run-wait-endpoint-xcom branch from 45e043e to ea0e56d Compare March 30, 2026 05:18
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@pierrejeambrun pierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun pierrejeambrun added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Mar 30, 2026
@pierrejeambrun pierrejeambrun merged commit 35ca494 into apache:main Mar 30, 2026
148 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 30, 2026
… query parameter (#64415)

(cherry picked from commit 35ca494)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
… query parameter (apache#64415)

(cherry picked from commit 35ca494)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
… query parameter (#64415) (#64488)

(cherry picked from commit 35ca494)

Co-authored-by: Kevin Yang <85313829+sjyangkevin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants