Open
Conversation
We had some mismatch between the example dag vs readme. This fixes it as well as updates the error logging in the worker, earlier the failure was lost.
aritra24
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
area:go-sdk
backport-to-v3-2-test
uranusjr
reviewed
Mar 31, 2026
| )) | ||
| edgeVer.FromWorkerStateBodySysinfo0(edgeapi.WorkerStateBodySysinfo0( | ||
| configOrDefault("edge.provider_version", "3.2.0"), | ||
| configOrDefault("edge.provider_version", "3.3.0"), |
Member
There was a problem hiding this comment.
Hm, do we want to change this? (Not sure what @ashb intended)
Contributor
There was a problem hiding this comment.
Oh good catch, I checked one commit and missed this. If we want to update this, we should do so for occurrences above too?
Collaborator
Author
There was a problem hiding this comment.
I had to make this change because the airflow version had incremented. We disallow using a newer version of airflow against an older worker.
Collaborator
Author
There was a problem hiding this comment.
I will recheck, but without the version bump it throws an error. And also this specific version was the one it was checking against. So I'd updated only this one.
amoghrajesh
dismissed
their stale review
Overlooked the version change, that will need fixing / explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some mismatch between the example
dag vs readme. This fixes it as well as updates
the error logging in the worker, earlier the failure was lost.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.