[v3-2-test] Fix per-option button rendering for 4 options (#64453)#64494
Draft
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Draft
[v3-2-test] Fix per-option button rendering for 4 options (#64453)#64494github-actions[bot] wants to merge 1 commit intov3-2-testfrom
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Conversation
The condition \`options.length < 4\` caused exactly 4 options to render nothing — shouldRenderOptionButton was false but no fallback UI was triggered either. Changed to \`options.length <= 4\` so 4 options render as buttons. Fixes #64413 * add ci fixes --------- (cherry picked from commit a48d8a5) Co-authored-by: Shrividya Hegde <5312302+Shrividya@users.noreply.github.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition `options.length < 4` caused exactly 4 options to render
nothing — shouldRenderOptionButton was false but no fallback UI was
triggered either. Changed to `options.length <= 4` so 4 options render
as buttons.
Fixes #64413
(cherry picked from commit a48d8a5)
Co-authored-by: Shrividya Hegde 5312302+Shrividya@users.noreply.github.com
Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com