Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Grafana provider integration to support Grafana Loki as a remote logging backend in Airflow, including packaging/workspace registration.
Changes:
- Registers
apache-airflow-providers-grafanain the workspace and adds agrafanaextra. - Introduces a Loki remote log IO + task handler implementation to upload/read task logs via Loki’s HTTP API.
- Adds unit tests validating upload cleanup behavior, label cardinality strategy, and generated LogQL.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
uv.lock |
Adds the Grafana provider package to the lock/workspace metadata and updates extras/dependency markers. |
pyproject.toml |
Registers the new provider, adds grafana extra + mypy paths, and adjusts a couple of provider extra markers. |
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py |
Implements LokiRemoteLogIO and LokiTaskHandler for Loki push/query and Airflow logging integration. |
providers/grafana/tests/unit/grafana/loki/log/test_loki_task_handler.py |
Adds unit tests for Loki upload and query behavior. |
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/tests/unit/grafana/loki/log/test_loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/src/airflow/providers/grafana/loki/log/loki_task_handler.py
Outdated
Show resolved
Hide resolved
providers/grafana/tests/unit/grafana/loki/log/test_loki_task_handler.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
closing in favor of sidecar strategy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loki remote logging, partially resolves #64639
Was generative AI tooling used to co-author this PR?
Generated by Gemini 3.1 Pro with Antigravity.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.