Gate raw Dag deserialization error detail behind api.expose_stacktrace and log it server-side#68388
Open
potiuk wants to merge 1 commit into
Open
Conversation
…e and log it server-side Generated-by: Claude Opus 4.8 (1M context) following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
potiuk
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DagErrorHandlerinterpolated the rawstr(exc)of aDeserializationErrordirectly into the HTTP 500detail, ignoring theapi.expose_stacktracesetting that its sibling_UniqueConstraintErrorHandleralready honors. This makes the two handlers consistent: the raw exception text is returned only whenexpose_stacktraceis enabled; otherwise the response carries a generic message plus a correlation id, and the full error is logged server-side (previously it was not logged at all).api.expose_stacktrace, mirroring_UniqueConstraintErrorHandler.expose_stacktrace=True; a new case asserts the detail is withheld + an id is returned + the error is logged when off.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 (1M context) following the guidelines at
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions