Revert #59691: it broke per-index trigger rules in mapped task groups#68418
Open
potiuk wants to merge 1 commit into
Open
Revert #59691: it broke per-index trigger rules in mapped task groups#68418potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
…apache#59691)" This reverts commit a5ffa6c.
Member
Author
|
cc: @SameerMesiah97 reverting your change to unbreak main - you will have to redo it |
Contributor
Okay. I understand completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #59691 (
a5ffa6c794).#59691 regressed per-index trigger-rule evaluation in mapped task groups: a downstream task whose upstream is in the same mapped task group gets its summary instance (
map_index=-1) bound to upstream index0, so a single failed upstream instance marks the downstreamUPSTREAM_FAILEDand it never expands. This broketest_one_failed_trigger_rule_in_mapped_task_group_is_per_indexand turned theCore...Serializationjob red onmain(scheduled run 27376318492), blocking the merge queue.Reverting to green
mainimmediately. The proper redo (satisfying both #59691's and #50210's scenarios) is tracked in #68417.Verified locally: the previously-failing
test_one_failed_trigger_rule_in_mapped_task_group_is_per_indexandtest_one_failed_trigger_rule_runs_on_indirect_failure_in_mapped_task_grouppass after the revert.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines