Walk nested lists/tuples/sets in secrets masker key-name redaction#68422
Open
potiuk wants to merge 1 commit into
Open
Walk nested lists/tuples/sets in secrets masker key-name redaction#68422potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
The secrets masker walks dicts unconditionally for key-name-based redaction, so a sensitive key nested in dicts is masked at any depth. Lists, tuples, and sets were only walked below the recursion-depth cutoff, so a value carrying a sensitive key wrapped in an iterable beyond the cutoff was returned without key-name redaction. Walk nested lists/tuples/sets unconditionally too, mirroring the dict handling, keeping the depth cutoff only for pattern-based string masking. Add regression tests for sensitive keys wrapped in lists and tuples past MAX_RECURSION_DEPTH. Generated-by: Claude Opus 4.8 (1M context) following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secrets masker walks dicts unconditionally for key-name-based redaction, so a sensitive key nested in dicts is masked at any depth. Lists, tuples, and sets, however, were only walked below the recursion-depth cutoff — so a value carrying a sensitive key wrapped in an iterable beyond the cutoff was returned without key-name redaction.
This walks nested lists/tuples/sets unconditionally too, mirroring the dict handling, keeping the depth cutoff only for pattern-based string masking. Adds regression tests for sensitive keys wrapped in lists and tuples past
MAX_RECURSION_DEPTH.Tests
test_redact_sensitive_key_past_max_depthwith list- and tuple-wrapped cases past the cutofftest_redact_max_depth(pattern-masking depth bound) unchangedtest_secrets_masker.pysuite greenWas generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 (1M context) following the guidelines at
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions