Allow slashes in connection IDs fetched via the Execution API - #69228
Allow slashes in connection IDs fetched via the Execution API#69228justinpakzad wants to merge 2 commits into
Conversation
SameerMesiah97
left a comment
There was a problem hiding this comment.
Looks good. Also, this is the second PR I have seen that is addressing this exact same issue (PR #69178 is the first). It may be worth looking at all other API routes that accept user-defined identifiers to see if the same fix can be applied to those too.
|
Would appreciate a review on this. Thanks. |
09e4385 to
ad0c6c1
Compare
Correct, this doesn't address the connection secret without |
|
Would appreciate another set of eyes on this. Thanks. |
ad0c6c1 to
60b2763
Compare
60b2763 to
2884a88
Compare
|
Can someone please retrigger the MyPy providers check that was cancelled. Thanks. |
|
@amoghrajesh any thoughts on this? |
This PR adds a path converter to the
get_connectionroute in the Execution API so that connections whose IDs contain forward slashes can be fetched. Currently, the endpoint returns a 404 when fetching a connection with an ID such asdev/my_conn. This fix is mainly applicable for secrets backends, as connections created via the REST API/CLI do not allow slashes in theconn_id(although the Connection model itself does). Client-side encoding of theconn_idwas also added. Additional test cases were added to cover the new behavior (client and endpoint).related: #57864
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.