Fix the deadline_reference decorator's no-parentheses form - #70708
Merged
vatsrahul1001 merged 3 commits intoAug 3, 2026
Merged
Conversation
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
boring-cyborg
Bot
added
area:deadline-alerts
1 task
o-nikolas
approved these changes
Jul 30, 2026
vincbeck
approved these changes
Jul 30, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a couple issues with the
@deadline_referencedecorator while working on my Summit workshop.Docs implied that you could use
@deadline_referencewithout parentheses, as was intended behavior, but using it that way would cause a TypeError (without a particularly helpful message) later when it was called. This PR fixes support for the non-paren version, adds a clearer error message for a related instantiation issue, and cleans up the documentation a little to improve clarity.This is an additive fix, anything that was working before should still work unchanged.
Was generative AI tooling used to co-author this PR?
Generated-by: [Kiro-CLI (Claude Opus 5)] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.