-
Notifications
You must be signed in to change notification settings - Fork 17.5k
Fix log template sync failing when a custom SQL Alchemy schema is configured #70793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aaryan123456679
wants to merge
3
commits into
apache:main
Choose a base branch
from
Aaryan123456679:fix/logtemplate-custom-schema-47300
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−6
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1019,7 +1019,7 @@ def synchronize_log_template(*, session: Session = NEW_SESSION) -> None: | |
| from airflow.models.tasklog import LogTemplate | ||
|
|
||
| metadata = reflect_tables([LogTemplate], session) | ||
| log_template_table: Table | None = metadata.tables.get(LogTemplate.__tablename__) | ||
| log_template_table: Table | None = metadata.tables.get(LogTemplate.__table__.key) | ||
|
|
||
| if log_template_table is None: | ||
| log.info("Log template table does not exist (added in 2.3.0); skipping log template sync.") | ||
|
|
@@ -1104,11 +1104,20 @@ def reflect_tables(tables: list[MappedClassProtocol | str] | None, session, sche | |
| else: | ||
| for tbl in tables: | ||
| try: | ||
| table_name = tbl if isinstance(tbl, str) else tbl.__tablename__ | ||
| tbl_schema: str | None | ||
| tbl_schema, sep, name = table_name.partition(".") | ||
| if not sep: | ||
| tbl_schema, name = None, table_name | ||
| if isinstance(tbl, str): | ||
| tbl_schema, sep, name = tbl.partition(".") | ||
| if not sep: | ||
| tbl_schema, name = None, tbl | ||
| else: | ||
| # A mapped class already carries its configured schema (e.g. via | ||
| # ``sql_alchemy_schema``) on its table; a bare ``__tablename__`` would | ||
| # discard it and fall back to the connection's default schema. | ||
| # ``__table__`` isn't declared on ``MappedClassProtocol`` (SQLAlchemy sets | ||
| # it dynamically, invisible to mypy's static checks here), so read it via | ||
| # ``getattr`` instead of a direct attribute access. | ||
| name = tbl.__tablename__ | ||
| tbl_schema = getattr(tbl, "__table__").schema | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using the |
||
| metadata.reflect( | ||
| bind=bind, schema=tbl_schema, only=[name], extend_existing=True, resolve_fks=False | ||
| ) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would trim the entire comment down to a few words or even remove it compeletely and let users refer to the PR for more context.