Fix Windows compatibility in prek scripts and POSIX-only test skip gu… - #70946
Open
Adityakk9031 wants to merge 1 commit into
Open
Fix Windows compatibility in prek scripts and POSIX-only test skip gu…#70946Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
Adityakk9031
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
August 2, 2026 17:52
boring-cyborg
Bot
added
area:dev-tools
area:task-sdk
backport-to-v3-3-test
Author
|
@potiuk have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #69464 (follow-up)
Three Windows-compatibility fixes split out from #69504 per maintainer review:
common_prek_utils.py: explicit encoding="utf-8" on all read_text() calls prevents UnicodeDecodeError on Windows where the default codec is cp1252
shared/observability/.../stats.py: guard os.register_at_fork with hasattr since it is POSIX-only
test_supervisor.py / test_task_runner.py: skip on Windows with pytestmark rather than stubbing out POSIX syscalls — CI on Linux runs all tests as normal