[v3-3-test] Limit deadline alerts endpoint to the latest serialized Dag row (#70804) - #70965
Merged
Conversation
…ag row (#70804) * The deadline alerts endpoint fetches the latest serialized Dag by ordering all rows for a dag_id descending and reading the first one. Without a LIMIT, the database materializes every serialized version of the Dag when only the newest is needed. Cap the lookup at a single row. * Sort imports in deadline alerts UI route tests * UI: Allow reading deadline alerts of a specific Dag version A backfill run executes the Dag version that was current when it was queued, whose deadline alerts may differ from the ones deployed today. The endpoint could only ever resolve the newest serialized Dag, so the UI reported present-day alerts for historical runs and misrepresented what those runs were actually held to. Resolving the version through DagVersion.version_number also removes a reliance on the serialized_dag primary key sorting chronologically, which only held because uuid7 happens to be time-ordered and would give the wrong row if an older version were serialized after a newer one. Only the primary key is read, so the serialized Dag blob no longer crosses the wire for a lookup that discards it. (cherry picked from commit 1b3121d) Co-authored-by: Richard <richard9@ualberta.ca>
1 task
boring-cyborg
Bot
added
area:API
eladkal
marked this pull request as ready for review
August 3, 2026 05:55
eladkal
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 3, 2026 05:55
bbovenzi
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deadline alerts endpoint fetches the latest serialized Dag by
ordering all rows for a dag_id descending and reading the first one.
Without a LIMIT, the database materializes every serialized version of
the Dag when only the newest is needed. Cap the lookup at a single row.
Sort imports in deadline alerts UI route tests
UI: Allow reading deadline alerts of a specific Dag version
A backfill run executes the Dag version that was current when it was
queued, whose deadline alerts may differ from the ones deployed today.
The endpoint could only ever resolve the newest serialized Dag, so the
UI reported present-day alerts for historical runs and misrepresented
what those runs were actually held to.
Resolving the version through DagVersion.version_number also removes a
reliance on the serialized_dag primary key sorting chronologically,
which only held because uuid7 happens to be time-ordered and would give
the wrong row if an older version were serialized after a newer one.
Only the primary key is read, so the serialized Dag blob no longer
crosses the wire for a lookup that discards it.
(cherry picked from commit 1b3121d)
Co-authored-by: Richard richard9@ualberta.ca