Reference asset events from asset_dag_run_queue - #70972
Open
uranusjr wants to merge 1 commit into
Open
Conversation
uranusjr
requested review from
Lee-W,
XD-DENG,
ashb and
ephraimbuddy
as code owners
August 3, 2026 08:41
boring-cyborg
Bot
added
area:API
uranusjr
force-pushed
the
explore/asset-registration-atomicity-option-c
branch
from
August 3, 2026 11:06
99ccc95 to
fc8d415
Compare
Asset-triggered scheduling had the scheduler reconstruct which AssetEvents fed a run from a created_at time window. The prior fix 9e5b770 committed each AssetEvent in separate short-lived sessions so it was visible early, but that broke atomicity. This commit changes the ADRQ to directly reference the asset event that generates it, instead of using an implicit asset_id + timestamp combination. Atomicity is restored since we no longer needs to commit separately to get the timestamps right, while still being able to reference the correct asset events from the ADRQ.
uranusjr
force-pushed
the
explore/asset-registration-atomicity-option-c
branch
from
August 3, 2026 12:40
fc8d415 to
7a06763
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More details in #70970.
Asset-triggered scheduling had the scheduler reconstruct which AssetEvents fed a run from a created_at time window. The prior fix #62501 committed each AssetEvent in separate short-lived sessions so it was visible early, but that broke atomicity.
This commit changes the ADRQ to directly reference the asset event that generates it, instead of using an implicit asset_id + timestamp combination. Atomicity is restored since we no longer needs to commit separately to get the timestamps right, while still being able to reference the correct asset events from the ADRQ.