Fix airflow config lint staying silent on conditional removal rules - #70977
Open
Eason09053360 wants to merge 1 commit into
Open
Fix airflow config lint staying silent on conditional removal rules#70977Eason09053360 wants to merge 1 commit into
Eason09053360 wants to merge 1 commit into
Conversation
Config changes that are only removed for one specific value carry a remove_if_equals marker. Lint treated the presence of that marker as a reason to say nothing at all, so users upgrading with any of the five affected settings -- including three breaking ones -- were told their configuration was ready for Airflow 3 and only discovered otherwise after the upgrade broke. Because the marker was tested for truthiness rather than for being unset, a rule keyed to an empty string was also reported unconditionally, warning about configurations that were in fact fine. airflowctl already resolved this in apache#66370; this brings the core CLI in line with the behaviour that command has shipped since.
Eason09053360
marked this pull request as ready for review
August 3, 2026 10:49
Eason09053360
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
August 3, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflow config lintnever reported the removal rules marked withremove_if_equals. The marker was treated as a reason to skip the rule entirely, so the current value was never compared against it and lint printed "No issues found" regardless. Five rules were affected, three of them breaking.Same fix as #66370, which corrected the parallel
ConfigChangeinairflow-ctlbut left the core CLI behind.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.