Stop airflow config update from writing a backup during dry-run - #70979
Draft
Eason09053360 wants to merge 1 commit into
Draft
Stop airflow config update from writing a backup during dry-run#70979Eason09053360 wants to merge 1 commit into
Eason09053360 wants to merge 1 commit into
Conversation
Without --fix the command is meant to be a pure preview, so it should leave the filesystem alone. Creating the .bak unconditionally also made the command abort before printing anything when the config directory is not writable, hiding the very preview the user asked for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflow config updatewithout--fixis documented as a dry-run, but it created theairflow.cfg.bakbackup unconditionally before the dry-run branch. That meant a pure-preview command mutated the filesystem, and when the config directory is not writable the command aborted withAirflowConfigExceptionbefore printing anything — so the preview the user asked for was never shown.The backup now happens only on the
--fixpath, next to the write it protects.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.