Add durable execution to SnowparkContainerJobOperator - #73512
Draft
justinpakzad wants to merge 1 commit into
Draft
justinpakzad wants to merge 1 commit into
justinpakzad wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Snowpark container services jobs are often long running jobs and the operator polls Snowflake until a terminal status is reached. As per the
ResumableJobMixindocumentation this operator is a textbook candidate for durable execution. If the worker is restarted or crashed mid-way through, the next retry reconnects to the already running SPCS job instead of submitting a duplicate. If the job has already completed, then polling is skipped and the job finalized. If the prior job had failed or no longer exists, a fresh job is submitted. By default the operator would now run in durable mode. It only applies to the synchronous polling path and has no effect withwait_for_completion=Falseordeferrable=True.Couple of changes worth mentioning:
poll_until_completeandget_job_resultcan finalize the job (check status, fetch logs, and drop the service) depending on the state of the job upon reconnect, so a flag was introduced (_poll_until_complete_ran) to avoid duplicate finalization. Similar approach to the SnowflakeSqlApiOperator._describe_statuswhich is used by the polling loop so Snowflake errors still surface, and get_job_status, which is used only for the reconnect decision.get_job_statuscatches an "object does not exist" error (errno 2003) and returns a not-found sentinel, so a non-existent service resubmits fresh instead of raising.ResumableJobMixinonly exists on Airflow 3.3+, the operator falls back to a stub on older versions so it stays importable and always submits fresh (same as the other operators that have durable execution).The existing operator tests were updated for the new methods and new tests cover the durable paths. This was also tested end to end against a Snowflake instance (please see screenshots in the comment below). A durable section was also added to the docs.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.