Skip to content

Keep message queue provider doc markers out of class docstrings - #73588

Merged
vincbeck merged 1 commit into
apache:mainfrom
aaron-y-chen:clean-message-queue-provider-doc-markers
Sep 23, 2026
Merged

vincbeck merged 1 commit into
apache:mainfrom
aaron-y-chen:clean-message-queue-provider-doc-markers

Conversation

@aaron-y-chen

@aaron-y-chen aaron-y-chen commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

related: #73509
related: #52712

While I was working on #73509, a bug was found in the docs.

Summary

Six message queue provider classes put Sphinx [START] / [END] doc markers inside the class docstring. The docstring leaves the module through two paths and only one of them strips the markers, so they are rendered as literal text on the published API reference pages, and are returned by help() and shown in IDE tooltips.

Live example: SqsMessageQueueProvider:

kinesis_follow_up_1



The same is visible today on the Kafka, Redis, Azure Service Bus and Pub/Sub API pages.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Opus-5] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the cleanup

@vincbeck
vincbeck merged commit 7fa8dd4 into apache:main Sep 23, 2026
206 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants