-
Notifications
You must be signed in to change notification settings - Fork 368
Modify the optimizer to support obtaining tasks from each AMS node for processing. #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…AMS node for processing. apache#3928
…AMS node for processing. apache#3928
…per in master-slave mode. apache#3928
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |
|
Please help with the code review. |
|
After resolving any conflicts in the code, I will initiate the first review on my end cc @wardlican |
1 similar comment
|
After resolving any conflicts in the code, I will initiate the first review on my end cc @wardlican |
# Conflicts: # amoro-ams/src/main/java/org/apache/amoro/server/ha/ZkHighAvailabilityContainer.java # amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java # amoro-ams/src/main/resources/mysql/upgrade.sql # amoro-ams/src/main/resources/postgres/upgrade.sql # amoro-ams/src/test/java/org/apache/amoro/server/AMSServiceTestBase.java
…troduces a new solution for storing allocation information based on a database.
Okay, I will resolve the conflicts based on the latest master branch and add support for a database-based storage solution for bucket allocation information, based on the latest HA (High Availability) scheme. @czy006 |
…troduces a new solution for storing allocation information based on a database.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3950 +/- ##
============================================
+ Coverage 22.12% 30.15% +8.02%
- Complexity 2461 4165 +1704
============================================
Files 445 658 +213
Lines 40897 53207 +12310
Branches 5767 6808 +1041
============================================
+ Hits 9050 16043 +6993
- Misses 31089 35957 +4868
- Partials 758 1207 +449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why are the changes needed?
In master-slave mode, the optimizer needs to support pulling optimization tasks from each ams node for processing.
Close #3928.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation