fix(parquet/compress): honor LZ4 raw destination contract - #1147
Merged
Conversation
fallintoplace
marked this pull request as ready for review
August 8, 2026 15:52
zeroshade
approved these changes
Aug 11, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
The LZ4 raw codec now honors the documented destination-buffer contract while preserving caller-provided storage when capacity is sufficient. The regression and broader Parquet tests cover the allocation, round-trip, and reuse behavior. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The LZ4 raw codec passed the provided capacity straight to CompressBlock. Nil or undersized destinations could panic instead of allocating as promised by Codec.Encode. This allocates the compression bound when the destination capacity is insufficient.
Test