fix(arrow): include REE value nullability in type equality - #1158
Draft
fallintoplace wants to merge 1 commit into
Draft
fix(arrow): include REE value nullability in type equality#1158fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
force-pushed
the
fix/ree-nullability-equality
branch
from
August 9, 2026 22:51
cc1f953 to
cfda77b
Compare
fallintoplace
marked this pull request as ready for review
August 9, 2026 22:51
fallintoplace
marked this pull request as draft
August 9, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
TypeEqual compares run-end and value data types for run-end encoded types, but it does not compare whether the value field is nullable. Structurally different types can therefore compare equal and produce the same type fingerprint.
What changes are included in this PR?
Include ValueNullable in run-end encoded type equality and fingerprints.
Are these changes tested?
Yes. The regression test verifies both comparison directions and distinct fingerprints for nullable and non-nullable value fields. The full arrow package suite passes.
Are there any user-facing changes?
Run-end encoded types with different value nullability now compare unequal and have different fingerprints.