fix(parquet/pqarrow): reject decimal overflow when writing integers - #1161
Draft
fallintoplace wants to merge 1 commit into
Draft
fix(parquet/pqarrow): reject decimal overflow when writing integers#1161fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
force-pushed
the
fix/parquet-decimal-write-overflow
branch
from
August 9, 2026 22:51
61e569b to
180883c
Compare
fallintoplace
marked this pull request as ready for review
August 9, 2026 22:51
fallintoplace
marked this pull request as draft
August 9, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When decimals are stored as Parquet integers, values outside the declared or physical precision can be narrowed to int32 or int64 without a runtime error. That can silently write a different value.
What changes are included in this PR?
Validate non-null Decimal128 and Decimal256 values against both their declared precision and the target integer precision before conversion, and return arrow.ErrInvalid when a value does not fit.
Are these changes tested?
Yes. The test covers Decimal128 and Decimal256 with both int32 and int64 Parquet storage. The full parquet/pqarrow package suite passes.
Are there any user-facing changes?
Invalid decimal arrays now return an error instead of producing corrupted integer values.